refactor: merge alternation wrapper effects into body instructions#279
Merged
refactor: merge alternation wrapper effects into body instructions#279
Conversation
715e490 to
c59f5ce
Compare
Enum/EndEnum effects into tagged alternation bodyc59f5ce to
edd7058
Compare
edd7058 to
7adc3f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CaptureEffectswithprefield for entry-point effectspreeffects to first instruction,postto lastEnumaspre_effect,EndEnumaspost_effectpre_effecton branch bodyWhy
Before: 3 instructions per tagged branch (
Enumepsilon → match →EndEnumepsilon)After: 1 instruction per branch with merged effects
Before: 2 instructions per untagged branch (
Null Setepsilon → match)After: 1 instruction with null injection as
pre_effectFor 30-branch tagged alternation: ~99 → 39 instructions (~60% reduction).